Skip to content

Add support for legacy storage operations#161

Merged
ske-prow[bot] merged 6 commits into
mainfrom
legacy-storage-mode
Jun 30, 2026
Merged

Add support for legacy storage operations#161
ske-prow[bot] merged 6 commits into
mainfrom
legacy-storage-mode

Conversation

@nschad

@nschad nschad commented Nov 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

How to categorize this PR?

/kind enhancement
/hold

What this PR does / why we need it:

Used for migrating SKE volumes, not relevant for external workload.

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension labels Nov 12, 2025
@nschad nschad marked this pull request as draft November 12, 2025 09:05
@ske-prow ske-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2025
@ske-prow ske-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2026
@nschad nschad force-pushed the legacy-storage-mode branch from 8183d3a to 3a6610a Compare April 27, 2026 07:44
@ske-prow ske-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2026
@nschad nschad marked this pull request as ready for review April 29, 2026 07:34
@ske-prow ske-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2026
@nschad nschad requested a review from a team May 5, 2026 08:47
@nschad nschad force-pushed the legacy-storage-mode branch 2 times, most recently from 16bfc44 to 3f3eeb2 Compare June 17, 2026 10:28
@ftl ftl mentioned this pull request Jun 18, 2026
Open
@nschad nschad force-pushed the legacy-storage-mode branch from 46ec65e to a2bbf9f Compare June 25, 2026 13:50
nschad added 5 commits June 25, 2026 18:40
@nschad
Add support for legacy storage operations
1195b01 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad
add flag to block volume creation
4601c04 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad
update error text
56ca256 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad
adjust calculateMaxVolumesPerNode() depending on which driverName is …
17861f7 
…configured

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad
use correct name for flag to control support for enabling/disabling l…
e53b433 
…egacy volume creation

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad nschad force-pushed the legacy-storage-mode branch from a2bbf9f to e53b433 Compare June 25, 2026 16:40
@nschad
use codes.Unimplemented instead of codes.FailedPrecondition
8c5ea3d 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad

nschad commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@ske-prow ske-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2026
@ftl

ftl commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
@ske-prow

ske-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: d3bdf93cebea55d156febd81098176e8d2a1eca6

@nschad

nschad commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

/approve
/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@stackit-ske

stackit-ske commented Jun 30, 2026

Copy link
Copy Markdown

@nschad: once the present PR merges, I will cherry-pick it on top of release-v1.33, release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/approve
/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow

ske-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026
@ske-prow ske-prow Bot merged commit 23b82fd into main Jun 30, 2026
3 checks passed
@ske-prow ske-prow Bot deleted the legacy-storage-mode branch June 30, 2026 13:00
@stackit-ske

stackit-ske commented Jun 30, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1288

Details

In response to this:

/approve
/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 30, 2026
Merged
Merged
@stackit-ske

stackit-ske commented Jun 30, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1289

Details

In response to this:

/approve
/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jun 30, 2026
Merged
@stackit-ske

stackit-ske commented Jun 30, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1290

Details

In response to this:

/approve
/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske

stackit-ske commented Jun 30, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1291

Details

In response to this:

/approve
/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jun 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nschad @ftl @stackit-ske